Skip to content

Update condition for showing verify email button in faucet claim section #5394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2024
Merged

Update condition for showing verify email button in faucet claim section #5394

merged 1 commit into from
Nov 12, 2024
+4 −1

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 12, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR updates the condition for allowing users to claim from the faucet by incorporating email verification checks.

Detailed summary

  • Changed the condition from checking if the accountQuery.data.status is "noCustomer" to checking if both accountQuery.data.emailConfirmedAt is falsy and accountQuery.data.unconfirmedEmail is falsy.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: daae1dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Nov 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 7:38pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 12, 2024 7:38pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 12, 2024 7:38pm
wallet-ui ⬜️ Skipped (Inspect) Nov 12, 2024 7:38pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 12, 2024 17:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 12, 2024 17:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 12, 2024 17:20 Inactive
@MananTank MananTank marked this pull request as ready for review November 12, 2024 17:20
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 12, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Nov 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (afb6343) to head (daae1dc).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5394   +/-   ##
=======================================
  Coverage   45.70%   45.70%           
=======================================
  Files        1070     1070           
  Lines       55671    55671           
  Branches     4081     4081           
=======================================
  Hits        25446    25446           
  Misses      29536    29536           
  Partials      689      689
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from afb6343
packages 40.85% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.05 KB (0%) 862 ms (0%) 317 ms (-8.25% 🔽) 1.2 s
thirdweb (cjs) 103.17 KB (0%) 2.1 s (0%) 814 ms (+16.93% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 4.86 KB (0%) 98 ms (0%) 18 ms (-64.05% 🔽) 115 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 23 ms (+398.65% 🔺) 33 ms
thirdweb/react (minimal + tree-shaking) 17.58 KB (0%) 352 ms (0%) 158 ms (+264.89% 🔺) 509 ms

@MananTank MananTank changed the title Update condition for showing verify you email button in faucet claim section Update condition for showing verify your email button in faucet claim section Nov 12, 2024
@MananTank MananTank changed the title Update condition for showing verify your email button in faucet claim section Update condition for showing verify email button in faucet claim section Nov 12, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 12, 2024 •
edited
Loading

Merge activity

@MananTank
Update condition for showing verify email button in faucet claim sect…
daae1dc 
…ion (#5394)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the email verification logic for claiming from the faucet in the `FaucetButton` component. It changes the condition to check for both unconfirmed email and the absence of a confirmed email.

### Detailed summary
- Modified the condition to check if `emailConfirmedAt` is falsy and if `unconfirmedEmail` is truthy.
- Removed the previous check for `accountQuery.data.status === "noCustomer"`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 11-12-update_condition_for_showing_verify_you_email_button_in_faucet_claim_section branch from d26b4c4 to daae1dc Compare November 12, 2024 19:29
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 12, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 12, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 12, 2024 19:29 Inactive
@graphite-app graphite-app bot merged commit daae1dc into main Nov 12, 2024
31 of 32 checks passed
@graphite-app graphite-app bot deleted the 11-12-update_condition_for_showing_verify_you_email_button_in_faucet_claim_section branch November 12, 2024 19:39
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 12, 2024 19:39 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 12, 2024 19:39 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 12, 2024 19:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls